From 123639e3db0757fb3370516f7eaf50cbfae4d026 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Mon, 7 Sep 2026 08:12:24 +0100 Subject: delete util/libreboot-utils (unused code) this was an intense audit of nvmutil that somehow evolved into writing a new, hardened implementation of mktemp. it all works, a few memory bugs to solve on bsd, but i don't see the point in keeping it. mktemp is fine, and nvmutil already works. lbutils implemented atomic writes and integrity checking, in a manner completely overengineered for what it was actually doing (modifying a few bytes in 8KB GbE files) just delete it. i'll bring it back if i ever finish the code. i don't want to leave dead/unfinished code in the tree. Signed-off-by: Leah Rowe --- util/libreboot-utils/lib/state.c | 164 --------------------------------------- 1 file changed, 164 deletions(-) delete mode 100644 util/libreboot-utils/lib/state.c (limited to 'util/libreboot-utils/lib/state.c') diff --git a/util/libreboot-utils/lib/state.c b/util/libreboot-utils/lib/state.c deleted file mode 100644 index 78e15134..00000000 --- a/util/libreboot-utils/lib/state.c +++ /dev/null @@ -1,164 +0,0 @@ -/* SPDX-License-Identifier: MIT - * Copyright (c) 2022-2026 Leah Rowe - * - * State machine (singleton) for nvmutil data. - */ - -#ifndef _XOPEN_SOURCE -#define _XOPEN_SOURCE 700 -#endif - -#include -#include - -#include -#include -#include -#include -#include -#include -#include -#include -#include - -#include "../include/common.h" - -struct xstate * -xstart(int argc, char *argv[]) -{ - static int first_run = 1; - static char *dir = NULL; - static char *base = NULL; - char *realdir = NULL; - char *tmpdir = NULL; - char *tmpbase_local = NULL; - - static struct xstate us = { - { - /* be careful when modifying xstate. you - * must set everything precisely */ - { - CMD_DUMP, "dump", cmd_helper_dump, ARGC_3, - ARG_NOPART, - SKIP_CHECKSUM_READ, SKIP_CHECKSUM_WRITE, - NVM_SIZE, O_RDONLY - }, { - CMD_SETMAC, "setmac", cmd_helper_setmac, ARGC_3, - ARG_NOPART, - CHECKSUM_READ, CHECKSUM_WRITE, - NVM_SIZE, O_RDWR - }, { - CMD_SWAP, "swap", cmd_helper_swap, ARGC_3, - ARG_NOPART, - CHECKSUM_READ, SKIP_CHECKSUM_WRITE, - GBE_PART_SIZE, O_RDWR - }, { - CMD_COPY, "copy", cmd_helper_copy, ARGC_4, - ARG_PART, - CHECKSUM_READ, SKIP_CHECKSUM_WRITE, - GBE_PART_SIZE, O_RDWR - }, { - CMD_CAT, "cat", cmd_helper_cat, ARGC_3, - ARG_NOPART, - CHECKSUM_READ, SKIP_CHECKSUM_WRITE, - GBE_PART_SIZE, O_RDONLY - }, { - CMD_CAT16, "cat16", cmd_helper_cat16, ARGC_3, - ARG_NOPART, - CHECKSUM_READ, SKIP_CHECKSUM_WRITE, - GBE_PART_SIZE, O_RDONLY - }, { - CMD_CAT128, "cat128", cmd_helper_cat128, ARGC_3, - ARG_NOPART, - CHECKSUM_READ, SKIP_CHECKSUM_WRITE, - GBE_PART_SIZE, O_RDONLY - } - }, - - /* ->mac */ - {NULL, "xx:xx:xx:xx:xx:xx", {0, 0, 0}}, /* .str, .rmac, .mac_buf */ - - /* .f */ - {0}, - - /* ->i (index to cmd[]) */ - 0, - - /* .no_cmd (set 0 when a command is found) */ - 1, - - /* .cat (cat helpers set this) */ - -1 - - }; - - if (!first_run) - return &us; - - if (argc < 3) - exitf("xstart: Too few arguments"); - if (argv == NULL) - exitf("xstart: NULL argv"); - - first_run = 0; - - us.f.buf = us.f.real_buf; - - us.f.fname = argv[1]; - - us.f.tmp_fd = -1; - us.f.tname = NULL; - - if ((realdir = realpath(us.f.fname, NULL)) == NULL) - exitf("xstart: can't get realpath of %s", - us.f.fname); - - if (fs_dirname_basename(realdir, &dir, &base, 0) < 0) - exitf("xstart: don't know CWD of %s", - us.f.fname); - - sdup(base, PATH_MAX, &us.f.base); - - us.f.dirfd = fs_open(dir, - O_RDONLY | O_DIRECTORY); - if (us.f.dirfd < 0) - exitf("%s: open dir", dir); - - if (new_tmpfile(&us.f.tmp_fd, &us.f.tname, dir, ".gbe.XXXXXXXXXX") < 0) - exitf("%s", us.f.tname); - - if (fs_dirname_basename(us.f.tname, - &tmpdir, &tmpbase_local, 0) < 0) - exitf("tmp basename"); - - sdup(tmpbase_local, PATH_MAX, &us.f.tmpbase); - - free_and_set_null(&tmpdir); - - if (us.f.tname == NULL) - exitf("x->f.tname null"); - if (*us.f.tname == '\0') - exitf("x->f.tname empty"); - - if (fstat(us.f.tmp_fd, &us.f.tmp_st) < 0) - exitf("%s: stat", us.f.tname); - - memset(us.f.real_buf, 0, sizeof(us.f.real_buf)); - memset(us.f.bufcmp, 0, sizeof(us.f.bufcmp)); - - /* for good measure */ - memset(us.f.pad, 0, sizeof(us.f.pad)); - - return &us; -} - -struct xstate * -xstatus(void) -{ - struct xstate *x = xstart(0, NULL); - - if (x == NULL) - exitf("NULL pointer to xstate"); - - return x; -} -- cgit v1.2.1