From 4afa0aaa3c0294cf8e07e7be4022e9c8ea466a86 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Sat, 30 Sep 2023 13:21:15 +0100 Subject: build/boot/roms: check all targets before building If one of them doesn't exist, error out. Previously, a build would start but then it would error out later on. This implements the mentality: fail early, fail hard Signed-off-by: Leah Rowe --- script/build/boot/roms | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) (limited to 'script') diff --git a/script/build/boot/roms b/script/build/boot/roms index 9ddbb03e..f80e2a3a 100755 --- a/script/build/boot/roms +++ b/script/build/boot/roms @@ -57,15 +57,23 @@ handle_targets() [ "${first}" != "all" ] || boards="$(listitems config/coreboot)" || \ err "handle_targets: Cannot get list of boards" + check_targets + for board in ${boards}; do - [ -d "config/coreboot/${board}/" ] || \ - err "handle_targets: target not defined: ${board}" ./build boot roms_helper ${board}${opts} || \ err "handle_targets ${board}${opts}: build error" [ -d "bin/${board}" ] && targets="${board} ${targets}" done } +check_targets() +{ + for board in ${boards}; do + [ -d "config/coreboot/${board}/" ] || \ + err "check_targets: target not defined: ${board}" + done +} + confirm_targets() { [ -z "${targets}" ] && err "No ROM images were compiled." -- cgit v1.2.1