From 84bf47b5b947a8ed5afa1fb5335266d04ee3b004 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Sat, 9 Sep 2023 23:15:17 +0100 Subject: scripts: better handling of printf: stdout/stderr in some cases, messages that should be considered errors or warnings, were being written to the standard output, rather than written as error messages. also: one or two printf statements should specifically avoid printing errors (to any file); in these cases, stdout has been redirected to /dev/null Signed-off-by: Leah Rowe --- script/update/blobs/download | 3 ++- script/update/blobs/mrc | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) (limited to 'script/update') diff --git a/script/update/blobs/download b/script/update/blobs/download index b9c801a6..71c0cdb6 100755 --- a/script/update/blobs/download +++ b/script/update/blobs/download @@ -38,7 +38,8 @@ detect_firmware() [ "${CONFIG_INCLUDE_SMSC_SCH5545_EC_FW}" = "y" ] && \ needs="${needs} SCH5545EC" [ -z ${needs+x} ] && \ - printf "No binary blobs needed for this board\n" && \ + printf "No binary blobs needed for board: %s\n" "${board}" \ + 1>&2 && \ return 1 printf "Firmware needed for board '%s':\n%s\n" "${board}" "${needs}" } diff --git a/script/update/blobs/mrc b/script/update/blobs/mrc index e4de2be4..681b3699 100755 --- a/script/update/blobs/mrc +++ b/script/update/blobs/mrc @@ -62,11 +62,11 @@ check_existing() { [ -f "${_mrc_complete}" ] || \ return 0 - printf 'found existing mrc.bin\n' + printf "found existing mrc.bin\n" 1>&2 [ "$(sha512sum "${_mrc_complete}" | awk '{print $1}')" \ = "${_mrc_complete_hash}" ] && \ return 1 - printf 'hashes did not match, starting over\n' + printf "hashes did not match, starting over\n" 1>&2 } build_dependencies() -- cgit v1.2.1