From 5aef8156b50e0fd2a13c4765a333181346096b09 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Sat, 9 Sep 2023 23:31:20 +0100 Subject: scripts: use printf, not echo, where appropriate printf has more universal behaviour, across various implementations of sh, so it's better to use this. Signed-off-by: Leah Rowe --- script/build/boot/roms_helper | 5 +++-- script/build/release/roms | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) (limited to 'script/build') diff --git a/script/build/boot/roms_helper b/script/build/boot/roms_helper index fb25bba4..5b64ad0e 100755 --- a/script/build/boot/roms_helper +++ b/script/build/boot/roms_helper @@ -156,7 +156,7 @@ configure_target() # Override all payload directives with cmdline args if [ ! -z ${payloads} ]; then - echo "setting payloads $payloads" + printf "setting payloads %s\n" "$payloads" payload_grub="n" payload_grub_withseabios="n" # seabios chainloaded from grub payload_seabios="n" @@ -397,7 +397,8 @@ build_grub_roms() { done fi for keymapfile in ${keymaps}; do - echo "keymaps is $keymaps, keymapfile is $keymapfile" + printf "keymaps is %s, keymapfile is %s\n" \ + "${keymaps}" "${keymapfile}" [ -f "${keymapfile}" ] || continue diff --git a/script/build/release/roms b/script/build/release/roms index da67f8ed..c15087f5 100755 --- a/script/build/release/roms +++ b/script/build/release/roms @@ -97,7 +97,7 @@ make_archive() cp "${builddir}"/* "${romdir}" || \ err "make_archive: cannot copy ROM images directory -> ${romdir}" - echo ${target} + printf "%s\n" "${target}" microcode_required="y" . "config/coreboot/${target}/target.cfg" -- cgit v1.2.1