From 308c21dd438e5dc27b232a0c31f0e68244ab364f Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Sun, 10 Sep 2023 15:05:19 +0100 Subject: build/boot/roms stragglers: properly handle errors there were a few missing err calls i actually went through all of lbmk and found no instances where err calls were missing except in build/boot/roms_helper Signed-off-by: Leah Rowe --- script/build/boot/roms_helper | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'script/build') diff --git a/script/build/boot/roms_helper b/script/build/boot/roms_helper index 5b64ad0e..ff8772eb 100755 --- a/script/build/boot/roms_helper +++ b/script/build/boot/roms_helper @@ -317,7 +317,8 @@ build_seabios_roms() else x=${corebootrom} y=${initmode} - t=$(mkSeabiosRom "$x" "fallback/payload" "$y") + t=$(mkSeabiosRom "$x" "fallback/payload" "$y") || \ + err "build_seabios_roms: cannot build tmprom" if [ "${initmode}" = "normal" ]; then newrompath="${romdir}/seabios_${board}_" newrompath="${newrompath}${initmode}.rom" @@ -347,7 +348,9 @@ build_grub_roms() { y=${initmode} if [ "${payload_grub_withseabios}" = "y" ] && \ [ "${firstpayloadname}" = "grub" ]; then - mv "$(mkSeabiosRom "${x}" "seabios.elf" "${y}")" "${tmprompath}" + mv "$(mkSeabiosRom "${x}" "seabios.elf" "${y}")" \ + "${tmprompath}" || \ + err "build_grub_roms: cannot move tmp rom (seabios.elf)" elif [ "${payload_seabios_withgrub}" = "y" ] && \ [ "${firstpayloadname}" != "grub" ]; then mv "$(mkSeabiosRom "${x}" "fallback/payload" "$y")" \ -- cgit v1.2.1