From 26fc3f13254e38ddd6903e7e18e0945b4e6fe63d Mon Sep 17 00:00:00 2001
From: Leah Rowe <leah@libreboot.org>
Date: Sat, 30 Sep 2023 20:04:02 +0100
Subject: general code formatting cleanup in shell scripts

Signed-off-by: Leah Rowe <leah@libreboot.org>
---
 script/build/release/roms | 27 +++++++++++----------------
 1 file changed, 11 insertions(+), 16 deletions(-)

(limited to 'script/build/release/roms')

diff --git a/script/build/release/roms b/script/build/release/roms
index 4a18037d..026f4eae 100755
--- a/script/build/release/roms
+++ b/script/build/release/roms
@@ -46,10 +46,9 @@ init_check()
 	[ ! -d "release/${version}/roms/" ] || \
 		rm -Rf "release/${version}/roms/" || \
 		    err "init_check: !rm -Rf release/${version}/roms/"
-	if [ ! -d "release/${version}/roms/" ]; then
-		mkdir -p "release/${version}/roms/" || \
-		    err "init_check: !mkdir -p release/${version}/roms/"
-	fi
+	[ -d "release/${version}/roms/" ] && return 0
+	mkdir -p "release/${version}/roms/" || \
+	    err "init_check: !mkdir -p release/${version}/roms/"
 }
 
 make_archive()
@@ -161,20 +160,17 @@ strip_archive()
 strip_ucode()
 {
 	romfile=${1}
-
 	_newrom_b="${romfile%.rom}_nomicrocode.tmprom"
 	cp "${romfile}" "${_newrom_b}" || \
 	    err "strip_rom_image: cp \"${romfile}\" \"${_newrom_b}\""
 	microcode_present="y"
 	"${cbfstool}" "${_newrom_b}" remove -n \
 	    cpu_microcode_blob.bin 2>/dev/null || microcode_present="n"
-	if [ "${microcode_present}" = "n" ]; then
-		printf "REMARK: '%s' already lacks microcode\n" "${romfile}" \
-		    1>&2
-		printf "Renaming default ROM file instead.\n" 1>&2
-		mv "${romfile}" "${_newrom_b}" || \
-		    err "strip_rom_image: can't rename no-u ${romfile}"
-	fi
+	[ "${microcode_present}" = "n" ] || return 0
+	printf "REMARK: '%s' already lacks microcode\n" "${romfile}" 1>&2
+	printf "Renaming default ROM file instead.\n" 1>&2
+	mv "${romfile}" "${_newrom_b}" || \
+	    err "strip_rom_image: can't rename no-u ${romfile}"
 }
 
 strip_rom_image()
@@ -196,10 +192,9 @@ strip_rom_image()
 		    err "strip_rom_images: ${1}: can't nuke ecfw2.bin"
 	fi
 	# TODO: replace this board-specific hack
-	if [ "${target}" = "e6400_4mb" ]; then
-		"${cbfstool}" "${1}" remove -n "pci10de,06eb.rom" || \
-		    err "strip_rom_images: ${1}: can't nuke e6400 vga rom"
-	fi
+	[ "${target}" = "e6400_4mb" ] || return 0
+	"${cbfstool}" "${1}" remove -n "pci10de,06eb.rom" || \
+	    err "strip_rom_images: ${1}: can't nuke e6400 vga rom"
 }
 
 main $@
-- 
cgit v1.2.1