From 7b02bb9aa6e533f30f25133caf9d214ca3d5bda2 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Mon, 2 Oct 2023 03:39:10 +0100 Subject: do not handle errors on mktemp in shell scripts errors are not defined for mktemp, and the /tmp file system should be assumed reliable. if /tmp is *unreliable*, then this is not something that lbmk either can or should fix; the user clearly has bigger problems. manpages for mktemp do not define errors. it is assumed to be completely reliable. Signed-off-by: Leah Rowe --- script/build/boot/roms_helper | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'script/build/boot/roms_helper') diff --git a/script/build/boot/roms_helper b/script/build/boot/roms_helper index 2d185b7d..5685ef72 100755 --- a/script/build/boot/roms_helper +++ b/script/build/boot/roms_helper @@ -263,8 +263,7 @@ build_grub_roms() -n background.png -t raw fi - tmpcfg=$(mktemp -t coreboot_rom.XXXXXXXXXX) || - err "build_grub_roms: cannot create temporary scan.cfg" + tmpcfg=$(mktemp -t coreboot_rom.XXXXXXXXXX) x_ printf "set grub_scan_disk=\"%s\"\n" "${grub_scan_disk}" >"${tmpcfg}" [ "${grub_scan_disk}" = "both" ] || \ x_ "${cbfstool}" "${tmprom}" add -f "${tmpcfg}" -n scan.cfg -t raw @@ -302,8 +301,7 @@ mkGrubRom() { keymapcfg="elf/grub/keymap_${_keymap}.cfg" - tmprom=$(mktemp -t coreboot_rom.XXXXXXXXXX) || \ - err "mkGrubRom: cannot create tmprom" + tmprom=$(mktemp -t coreboot_rom.XXXXXXXXXX) x_ cp "${_cbrom}" "${tmprom}" x_ "${cbfstool}" "${tmprom}" add -f "${keymapcfg}" -n keymap.cfg -t raw -- cgit v1.2.1