From 7f5dfebf7d37c56d9c7993aaa17c59070cb5aec9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ferass=20=27Vitali64=27=20EL=C2=A0HAFIDI?= Date: Wed, 28 Dec 2022 19:29:18 +0100 Subject: Do not rely on bashisms and behaviour undefined by the POSIX specification. Part 2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Ferass 'Vitali64' EL HAFIDI --- resources/scripts/download/coreboot | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) (limited to 'resources/scripts/download/coreboot') diff --git a/resources/scripts/download/coreboot b/resources/scripts/download/coreboot index 727aacc2..821ee321 100755 --- a/resources/scripts/download/coreboot +++ b/resources/scripts/download/coreboot @@ -1,9 +1,10 @@ -#!/usr/bin/env bash +#!/usr/bin/env sh # helper script: download coreboot # # Copyright (C) 2014, 2015, 2016, 2020, 2021 Leah Rowe # Copyright (C) 2022 Alper Nebi Yasak +# Copyright (C) 2022 Ferass El Hafidi # # This program is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -52,17 +53,17 @@ usage() # In this script, set -u is used to check for undefined variables, and # the test command doesn't do any lazy evaluation, so we can't use -# a syntax like that: [ $# -eq 1 -a "$1" == "--help" ]. +# a syntax like that: [ $# -eq 1 -a "$1" = "--help" ]. -if [ $# -eq 1 ] && [ "$1" == "--help" ] ; then +if [ $# -eq 1 ] && [ "$1" = "--help" ] ; then usage exit 0 -elif [ $# -eq 1 ] && [ "$1" == "--list-boards" ] ; then +elif [ $# -eq 1 ] && [ "$1" = "--list-boards" ] ; then list_supported_boards exit 0 fi -[[ -f build_error ]] && rm -f build_error +[ -f build_error ] && rm -f build_error rm -f resources/coreboot/*/seen @@ -90,7 +91,7 @@ downloadfor() { fi # This is to override $cbrevision and $cbtree - source "resources/coreboot/${board}/board.cfg" || touch ../build_error + . "resources/coreboot/${board}/board.cfg" || touch ../build_error if [ -f build_error ]; then printf "ERROR: download/coreboot: problem sourcing %s/board.cfg\n" "${board}" return 1 -- cgit v1.2.1