From 5a47c01b11a7fc25f7fae0685d288a78220b954a Mon Sep 17 00:00:00 2001
From: Leah Rowe <leah@libreboot.org>
Date: Sun, 27 Aug 2023 09:25:50 +0100
Subject: scripts: put quotes around file/directory names

Signed-off-by: Leah Rowe <leah@libreboot.org>
---
 resources/scripts/build/release/roms | 18 +++++++++---------
 resources/scripts/build/release/src  |  2 +-
 2 files changed, 10 insertions(+), 10 deletions(-)

(limited to 'resources/scripts/build/release')

diff --git a/resources/scripts/build/release/roms b/resources/scripts/build/release/roms
index bdc54c9b..395fb8d7 100755
--- a/resources/scripts/build/release/roms
+++ b/resources/scripts/build/release/roms
@@ -125,7 +125,7 @@ strip_archive()
 {
 	romdir=${1}
 
-	[ -d coreboot/${tree} ] || \
+	[ -d "coreboot/${tree}" ] || \
 		./fetch_trees coreboot ${tree} || \
 		    err "strip_archive: coreboot/${tree}: can't fetch source"
 	./build coreboot utils ${tree} || \
@@ -143,7 +143,7 @@ strip_archive()
 	    err "strip_archive: !touch ${blobdir}/blobhashes"
 
 	(
-	cd ${romdir} || err "strip_archive: !cd ${romdir}"
+	cd "${romdir}" || err "strip_archive: !cd ${romdir}"
 	sha1sum *.rom >> blobhashes || \
 	    err "strip_archive: ${romdir}: !sha1sum *.rom >> blobhashes"
 	)
@@ -160,7 +160,7 @@ strip_rom_image()
 	[ -f "${romfile}" ] || return 0
 
 	if [ "${CONFIG_HAVE_ME_BIN}" = "y" ]; then
-		${ifdtool} --nuke me "${romfile}" || \
+		"${ifdtool}" --nuke me "${romfile}" || \
 		    err "strip_rom_images: ${romfile}: cannot nuke Intel ME"
 		mv "${romfile}" "${romdir}_tmp" || \
 		    err "strip_rom_images: !mv ${romfile} ${romdir}_tmp"
@@ -169,25 +169,25 @@ strip_rom_image()
 	fi
 
 	if [ "${CONFIG_HAVE_MRC}" = "y" ]; then
-		${cbfstool} "${romfile}" remove -n mrc.bin || \
+		"${cbfstool}" "${romfile}" remove -n mrc.bin || \
 		    err "strip_rom_images: ${romfile}: cannot nuke mrc.bin"
-		${cbfstool} "${romfile}" print || :
+		"${cbfstool}" "${romfile}" print || :
 	fi
 
 	if [ "${CONFIG_KBC1126_FIRMWARE}" = "y" ]; then
-		${cbfstool} "${romfile}" remove -n ecfw1.bin || \
+		"${cbfstool}" "${romfile}" remove -n ecfw1.bin || \
 		    err "strip_rom_images: ${romfile}: can't nuke ecfw1.bin"
-		${cbfstool} "${romfile}" remove -n ecfw2.bin || \
+		"${cbfstool}" "${romfile}" remove -n ecfw2.bin || \
 		    err "strip_rom_images: ${romfile}: can't nuke ecfw2.bin"
 	fi
 
 	[ "${CONFIG_INCLUDE_SMSC_SCH5545_EC_FW}" != "y" ] || \
-		${cbfstool} "${romfile}" remove -n sch5545_ecfw.bin || \
+		"${cbfstool}" "${romfile}" remove -n sch5545_ecfw.bin || \
 		    err "strip_rom_images: ${romfile}: can't nuke sch5545ec fw"
 
 	# TODO: replace this board-specific hack
 	if [ "${target}" = "e6400nvidia_4mb" ]; then
-		${cbfstool} "${romfile}" remove -n "pci10de,06eb.rom" || \
+		"${cbfstool}" "${romfile}" remove -n "pci10de,06eb.rom" || \
 		    err "strip_rom_images: ${romfile}: can't nuke e6400 vga rom"
 	fi
 }
diff --git a/resources/scripts/build/release/src b/resources/scripts/build/release/src
index 498bfabb..2e1b7174 100755
--- a/resources/scripts/build/release/src
+++ b/resources/scripts/build/release/src
@@ -125,7 +125,7 @@ copy_blobs()
 			[ -e "${srcdir}/blobs/${i}" ] || \
 				mkdir -p "${srcdir}/blobs/${i}" || \
 				    err "copy_blobs: ! -d ${srcdir}/blobs/${i}"
-			cp blobs/${i}/${j}.bin "${srcdir}/blobs/${i}" || \
+			cp "blobs/${i}/${j}.bin" "${srcdir}/blobs/${i}" || \
 			    err "copy_blobs: ! -f ${srcdir}/blobs/${i}"
 		done
 	done
-- 
cgit v1.2.1