From 62f23123cb2a5ef594f405053d0b111c6e01de87 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Mon, 21 Aug 2023 19:41:49 +0100 Subject: general code cleanup on lbmk shell scripts in update/blobs/download, i saw instances where appdir was being deleted with rm -r, but the more appropriate command would rm -Rf. this is now fixed. other than that, i've mostly just simplified a bunch of if statements and consolidated some duplicated logic (e.g. if/else block for dependencies in build_dependencies() of update/blobs/download one or two functions and/or variables have been renamed, for greater clarity in the code, also removed a few messages that were redundant used printf instead of echo, in a few places, also fixed up the indentation in a few places Signed-off-by: Leah Rowe --- resources/scripts/build/clean/cbutils | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'resources/scripts/build/clean/cbutils') diff --git a/resources/scripts/build/clean/cbutils b/resources/scripts/build/clean/cbutils index de9a588f..dec8d944 100755 --- a/resources/scripts/build/clean/cbutils +++ b/resources/scripts/build/clean/cbutils @@ -33,12 +33,9 @@ rm -Rf cbutils [ ! -d "coreboot/" ] && exit 0 for tree in coreboot/*; do - if [ "${tree##*/}" = "coreboot" ]; then - continue - fi - if [ ! -d "${tree}" ]; then - continue - fi + [ "${tree##*/}" = "coreboot" ] && continue + [ -d "${tree}" ] || continue + # Clean coreboot, of course make -C "${tree}/" distclean -- cgit v1.2.1