From 137b5434d75352d2a0ddd56d5cc25ba59d9b0c5a Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Mon, 5 Dec 2022 00:10:07 +0000 Subject: remove logic for avoiding nonredistributable blobs the --nuke option in ifdtool will be used instead, to nuke the ME regions in specific rom sets (and cbfstool will be used to delete mrc.bin files from rom sets) the new method being implemented is heavier on disk io, but simplifies lbmk, and disk io could still be optimised in the following ways: * when copying roms from boards with ME in them, use ifdtool --nuke to get filename.rom.new, and *move* (not copy) filename.rom.new to the new destination (for use with tar) * possibly modify ifdtool to make efficient use of mmap for disk i/o; it currently loads entire roms into an allocated buffer in memory --- resources/scripts/build/boot/roms | 7 +------ resources/scripts/build/boot/roms_helper | 13 +------------ 2 files changed, 2 insertions(+), 18 deletions(-) (limited to 'resources/scripts/build/boot') diff --git a/resources/scripts/build/boot/roms b/resources/scripts/build/boot/roms index 94215028..c526c268 100755 --- a/resources/scripts/build/boot/roms +++ b/resources/scripts/build/boot/roms @@ -83,12 +83,7 @@ buildrom_release() { board="$1" if [ -d "resources/coreboot/${board}/" ]; then - ./build release deblob ${board} - if [ "$?" = 2 ]; then - ./build boot roms_helper "${board}" - else - ./build boot roms_helper deblobbed "${board}" - fi + ./build boot roms_helper "${board}" else die "\nbuild/roms: target not defined in the build system: %s\n" "${board}" fi diff --git a/resources/scripts/build/boot/roms_helper b/resources/scripts/build/boot/roms_helper index 40c0f394..bd1f3860 100755 --- a/resources/scripts/build/boot/roms_helper +++ b/resources/scripts/build/boot/roms_helper @@ -30,13 +30,6 @@ set -u -e projectname="$(cat projectname)" -if [ "${1}" = "deblobbed" ]; then - deblobbed=true - shift -else - deblobbed=false -fi - displaymodes="" payloads="" keyboard_layouts="" @@ -315,11 +308,7 @@ moverom() { # expected: configs must not specify a payload mkCoreboot() { cbdir="${1}" # e.g. coreboot/default - if ${deblobbed} ; then - cbcfgpath="${2}_deblobbed" - else - cbcfgpath="${2}" # e.g. resources/coreboot/x200_8mb/config/libgfxinit_txtmode - fi + cbcfgpath="${2}" # e.g. resources/coreboot/x200_8mb/config/libgfxinit_txtmode if [ ! -f "${cbcfgpath}" ]; then printf "\nmkCoreboot: Coreboot config '%s' does not exist. Skipping build.\n" \ "${cbcfgpath}" -- cgit v1.2.1