From 1c8401be25e4749a2eee5ddc77ce7c6ac880c910 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Thu, 24 Aug 2023 20:19:41 +0100 Subject: much, much stricter, more verbose error handling lbmk is much more likely to crash now, in error conditions, which is a boon for further auditing. also: in "fetch", remove the downloaded program if fail() was called. this would also be done for gnulib, when downloading grub, but done in such a way that gnulib goes first. where calls to err write "ERROR" in the string, they no longer say "ERROR" because the "err" function itself now does that automatically. also: listmodes/listoptions (in "lbmk") now reports an error if no scripts and/or directories are found. also: where a warning is given, but not an error, i've gone through in some places and redirected the output to stderr, not stdout as part of error checks: running anything as root, except for the "./build dependencies *" commands, is no longer permitted and lbmk will throw an error mrc downloads: debugfs output no longer redirected to /dev/null, and stderr no longer redirected to stdout. everything is verbose. certain non-error states are also more verbose. for example, patch_rom in blobs/inject will now state when injection succeeds certain actual errors(bugs) were fixed: for example, build/release/roms now correctly prepares the blobs hash files for a given target, containing only the files and checksums in the list. Previously, a printf message was included. Now, with this new code: blobutil/inject rightly verifies hashes. doing all of this in one giant patch is cleaner than 100 patches changing each file. even this is yet part of a much larger audit going on in the Libreboot project. Signed-off-by: Leah Rowe --- resources/scripts/build/boot/roms | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'resources/scripts/build/boot/roms') diff --git a/resources/scripts/build/boot/roms b/resources/scripts/build/boot/roms index 966750a2..0aedfdb1 100755 --- a/resources/scripts/build/boot/roms +++ b/resources/scripts/build/boot/roms @@ -66,11 +66,11 @@ main() if [ "${firstoption}" = "all" ]; then for boardname in $(listboards); do - buildrom "${boardname}" || err "build/roms: error" + buildrom "${boardname}" || err "build/roms (1): error" done else for board in ${boards}; do - buildrom "${board}" || err "build/roms: error" + buildrom "${board}" || err "build/roms (2): error" done fi @@ -104,7 +104,7 @@ usage() listboards() { for boarddir in resources/coreboot/*; do - [ ! -d "${boarddir}" ] && continue + [ -d "${boarddir}" ] || continue board="${boarddir##resources/coreboot/}" board="${board%/}" printf '%s\n' "${board##*/}" @@ -115,7 +115,7 @@ listboards() buildrom() { [ -d "resources/coreboot/${1}/" ] || \ err "build/roms: target not defined: ${1}" - ./build boot roms_helper ${1}${opts} + ./build boot roms_helper ${1}${opts} || return 1 } main $@ -- cgit v1.2.1