From cdc0fb49e1c47a013ea99117acbf62e96ec5c652 Mon Sep 17 00:00:00 2001
From: Leah Rowe <leah@libreboot.org>
Date: Mon, 19 May 2025 23:07:01 +0100
Subject: get.sh: make xbmkget() easier to understand

the intent once again is that this for loop shall
return, with zero status, if success is observed.

otherwise, the loop breaks and an error is thrown.

Signed-off-by: Leah Rowe <leah@libreboot.org>
---
 include/get.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

(limited to 'include')

diff --git a/include/get.sh b/include/get.sh
index ab6ff401..89859454 100644
--- a/include/get.sh
+++ b/include/get.sh
@@ -85,8 +85,10 @@ xbmkget()
 	echk="f" && [ "$1" = "git" ] && echk="d"
 
 	for url in "$2" "$3"; do
-		[ -n "$url" ] && try_file "$url" "$@" && \
-		    eval "[ -$echk \"$4\" ] && return 0"
+		[ -n "$url" ] || continue
+		try_file "$url" "$@" || continue
+		eval "[ -$echk \"$4\" ] || continue"
+		return 0 # successful download/copy
 	done
 	err "$1 $2 $3 $4: not downloaded"; :
 }
-- 
cgit v1.2.1