From 4999a49de39667b3239fc2010d0e99c958b29417 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Thu, 11 Sep 2025 10:17:50 +0100 Subject: xbmk: don't use backticks for command substitution the newer way handles escaped characters better, and it can be nested more easily. it's also more readable. personally, i prefer the old way, because it's more minimalist, but it occurs to me that a lot of people nowadays don't know about backticks, but they do know of the modern way. to make the code more readable, i have modernised it. Signed-off-by: Leah Rowe --- include/rom.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'include/rom.sh') diff --git a/include/rom.sh b/include/rom.sh index bd58f974..223a84f3 100644 --- a/include/rom.sh +++ b/include/rom.sh @@ -32,8 +32,8 @@ copyps1bios() mkpayload_grub() { - eval "`setvars "" grub_modules grub_install_modules`" - $dry eval "`setcfg "$grubdata/module/$tree"`" + eval "$(setvars "" grub_modules grub_install_modules)" + $dry eval "$(setcfg "$grubdata/module/$tree")" $dry x_ rm -f "$srcdir/grub.elf"; $dry \ x_ "$srcdir/grub-mkstandalone" --grub-mkimage="$srcdir/grub-mkimage" \ -O i386-coreboot -o "$srcdir/grub.elf" -d "${srcdir}/grub-core/" \ @@ -256,7 +256,7 @@ cprom() newrom="${newrom%.rom}_${tmpnew%.gkb}.rom" irom="$tmprom" - [ $# -lt 1 ] || irom="`mktemp || err "!mk irom, $(echo "$@")"`" || err + [ $# -lt 1 ] || irom="$(mktemp || err "!mk irom, $(echo "$@")")" || err [ $# -gt 0 ] && x_ cp "$tmprom" "$irom" && cpcmd="mv" [ $# -gt 0 ] && [ "${1%.gkb}" != "$1" ] && \ -- cgit v1.2.1