From 0aca6332ee5865dbf4717235cbf9f5e8e79dddc3 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Sun, 24 Dec 2023 09:04:36 +0000 Subject: lbmk scripts: shorter code lines while seemingly pedantic, this does actually make code easier to read. mostly just switching to shorthand for variable names, where no expansions or patterns are used Signed-off-by: Leah Rowe --- include/mrc.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'include/mrc.sh') diff --git a/include/mrc.sh b/include/mrc.sh index 5ac09792..6a9b0a12 100755 --- a/include/mrc.sh +++ b/include/mrc.sh @@ -8,7 +8,7 @@ eval "$(setvars "" MRC_url MRC_url_bkup MRC_hash MRC_board SHELLBALL)" extract_mrc() { - [ -z "${MRC_board}" ] && err "extract_mrc $MRC_hash: MRC_board not set" + [ -z "$MRC_board" ] && err "extract_mrc $MRC_hash: MRC_board not set" [ -z "${CONFIG_MRC_FILE}" ] && \ err "extract_mrc $MRC_hash: CONFIG_MRC_FILE not set" @@ -21,7 +21,7 @@ extract_mrc() ) || err "mrc download/extract failure" "${cbfstool}" "${appdir}/"bios.bin extract -n mrc.bin \ - -f "${_dest}" -r RO_SECTION || err "extract_mrc: cbfstool ${_dest}" + -f "$_dest" -r RO_SECTION || err "extract_mrc: cbfstool $_dest" } extract_partition() @@ -38,5 +38,5 @@ extract_partition() err "extract_partition, dd ${1%.zip}, root-a.ext2" printf "cd /usr/sbin\ndump chromeos-firmwareupdate ${SHELLBALL}\nquit" \ - | debugfs "root-a.ext2" || err "extract_mrc: can't extract shellball" + | debugfs "root-a.ext2" || err "can't extract shellball" } -- cgit v1.2.1