From 9606c68c5b5becfb09da45e027e2398e5ff33dfa Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Tue, 31 Oct 2023 00:50:36 +0000 Subject: fix grub keyboard init on dell e6400 and e6430 also, enable seabios_withgrub on e6400, but not grubfirst; right now, we also support dgpu which would brick on grubfirst. on my tested nvidia model, loading grub from seabios worked, so i'm going to re-add seabios_grubfirst functionality like in older libreboot revisions, enabled selectively on a given target. e6430 currently only has igpu support anyway, but i've done the same thing there, in anticipation of future dgpu support. e6400 and e6430 ec report scancode set 2 with translation by default, but only actually output scancode set 1 grub is trying to use scancode set 2 without scancode translation, so the key inputs get messed up fix it by forcing scancode set 2 with translation, but only on coreboot; other build targets on GRUB will retain the same behaviour as before courtesy goes to Nicholas Chin who inspired me, and helped me to fix this. tested on Nicholas's E6400 and E6430, and my E6400; Riku also tested it on non-Dell, as did I (some thinkpads), and all seems OK. The new behaviour in coreboot GRUB is essentially no different to that of SeaBIOS, which does the same. Signed-off-by: Leah Rowe --- config/coreboot/e6400_4mb/target.cfg | 1 + config/coreboot/e6430_12mb/target.cfg | 1 + 2 files changed, 2 insertions(+) (limited to 'config/coreboot') diff --git a/config/coreboot/e6400_4mb/target.cfg b/config/coreboot/e6400_4mb/target.cfg index b5466aef..4cbaf904 100644 --- a/config/coreboot/e6400_4mb/target.cfg +++ b/config/coreboot/e6400_4mb/target.cfg @@ -5,5 +5,6 @@ payload_grub="n" payload_grub_withseabios="n" payload_seabios="y" payload_memtest="y" +payload_seabios_withgrub="y" grub_scan_disk="ahci" microcode_required="n" diff --git a/config/coreboot/e6430_12mb/target.cfg b/config/coreboot/e6430_12mb/target.cfg index 145aa712..7b790a99 100644 --- a/config/coreboot/e6430_12mb/target.cfg +++ b/config/coreboot/e6430_12mb/target.cfg @@ -4,5 +4,6 @@ arch="x86_64" payload_grub="n" payload_seabios_withgrub="n" payload_seabios="y" +payload_seabios_withgrub="y" payload_memtest="y" grub_scan_disk="ahci" -- cgit v1.2.1