From 99a88ebfa20421909675e9de6ed9376049f433d4 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Sat, 26 Oct 2024 05:41:46 +0100 Subject: Update dell 3050 patch to patch 15 (pwm fix) Use patchset 15 instead of 14: config/coreboot/default/patches/0061-WIP-OptiPlex-3050-Micro-port.patch Rebase the verb patch; patchset 15 modified the Makefile: config/coreboot/default/patches/0064-dell-optiplex_3050-add-hda_verb.c.patch We were using patchset 14 for the 3050 micro: https://review.coreboot.org/c/coreboot/+/82053/14 Now we use patchset 15: https://review.coreboot.org/c/coreboot/+/82053/15 Without this patch, the fans are always on a low setting, on the Dell OptiPlex 3050 Micro, even under stress conditions. With this patch, the fans change speed according to CPU temperature. I had to rebase my verb patch, because Mate modified the Makefile to add his sch5555 handler, on the same line where I add hda_verb. Mate tells me he will merge my verb and vbt patches into a further patchset later on. For now, I've simply rebased these patches on top of Mate's newer work; I've told him he can use them in his port. I'm probably going to now issue a new revision ROM image for Libreboot 20241008, so that users can get this fix sooner. Signed-off-by: Leah Rowe --- .../0064-dell-optiplex_3050-add-hda_verb.c.patch | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) (limited to 'config/coreboot/default/patches/0064-dell-optiplex_3050-add-hda_verb.c.patch') diff --git a/config/coreboot/default/patches/0064-dell-optiplex_3050-add-hda_verb.c.patch b/config/coreboot/default/patches/0064-dell-optiplex_3050-add-hda_verb.c.patch index d1427e22..df9accf8 100644 --- a/config/coreboot/default/patches/0064-dell-optiplex_3050-add-hda_verb.c.patch +++ b/config/coreboot/default/patches/0064-dell-optiplex_3050-add-hda_verb.c.patch @@ -1,7 +1,7 @@ -From 6731fef7759f4c67a6d0e85d16de9d99302c9b49 Mon Sep 17 00:00:00 2001 +From 782562bca3d9904e1e34f2cc6089876412b276cd Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Sun, 6 Oct 2024 17:25:27 +0100 -Subject: [PATCH 1/1] dell/optiplex_3050: add hda_verb.c +Subject: [PATCH 64/65] dell/optiplex_3050: add hda_verb.c Configured for the line jack at the front of the machine. @@ -10,16 +10,16 @@ Based on dumps from the vendor BIOS. Signed-off-by: Leah Rowe --- src/mainboard/dell/optiplex_3050/Kconfig | 1 + - src/mainboard/dell/optiplex_3050/Makefile.mk | 2 + + src/mainboard/dell/optiplex_3050/Makefile.mk | 3 +- src/mainboard/dell/optiplex_3050/hda_verb.c | 90 ++++++++++++++++++++ - 3 files changed, 93 insertions(+) + 3 files changed, 93 insertions(+), 1 deletion(-) create mode 100644 src/mainboard/dell/optiplex_3050/hda_verb.c diff --git a/src/mainboard/dell/optiplex_3050/Kconfig b/src/mainboard/dell/optiplex_3050/Kconfig -index 763acda0b2..777e29745a 100644 +index 2f0dccb98d..eab6034158 100644 --- a/src/mainboard/dell/optiplex_3050/Kconfig +++ b/src/mainboard/dell/optiplex_3050/Kconfig -@@ -18,6 +18,7 @@ config BOARD_SPECIFIC_OPTIONS +@@ -16,6 +16,7 @@ config BOARD_SPECIFIC_OPTIONS select SKYLAKE_SOC_PCH_H select SOC_INTEL_KABYLAKE select SUPERIO_SMSC_SCH555x @@ -28,14 +28,15 @@ index 763acda0b2..777e29745a 100644 config CBFS_SIZE default 0x900000 diff --git a/src/mainboard/dell/optiplex_3050/Makefile.mk b/src/mainboard/dell/optiplex_3050/Makefile.mk -index c078124332..1e2626967a 100644 +index d50ea40879..90b3cc4c48 100644 --- a/src/mainboard/dell/optiplex_3050/Makefile.mk +++ b/src/mainboard/dell/optiplex_3050/Makefile.mk -@@ -6,4 +6,6 @@ bootblock-y += sch5555_ec.c +@@ -5,5 +5,6 @@ bootblock-y += sch5555_ec.c + romstage-y += romstage.c - ramstage-y += ramstage.c -+ramstage-y += hda_verb.c +-ramstage-y += ramstage.c sch5555_ec.c ++ramstage-y += ramstage.c sch5555_ec.c hda_verb.c + ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads diff --git a/src/mainboard/dell/optiplex_3050/hda_verb.c b/src/mainboard/dell/optiplex_3050/hda_verb.c -- cgit v1.2.1