From cc2f08e7bbf9fc32bdd37079ee93b477ef4e8d09 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Mon, 14 Jul 2025 11:18:42 +0100 Subject: Revert "coreboot: rev 8b52167a9f 13 July 2025, rebase t480" This reverts commit 32dfdfbb01b84bb9c058e9b84305f15a14d4e231. The update caused an issue on T480: Backlight comes on, then off, then on, then off, repeatedly, and never gets to the payload. Will have to investigate further. Signed-off-by: Leah Rowe --- .../0030-dell-3050micro-disable-nvme-hotplug.patch | 49 ---------------------- 1 file changed, 49 deletions(-) delete mode 100644 config/coreboot/default/patches/0030-dell-3050micro-disable-nvme-hotplug.patch (limited to 'config/coreboot/default/patches/0030-dell-3050micro-disable-nvme-hotplug.patch') diff --git a/config/coreboot/default/patches/0030-dell-3050micro-disable-nvme-hotplug.patch b/config/coreboot/default/patches/0030-dell-3050micro-disable-nvme-hotplug.patch deleted file mode 100644 index 6fbfa632..00000000 --- a/config/coreboot/default/patches/0030-dell-3050micro-disable-nvme-hotplug.patch +++ /dev/null @@ -1,49 +0,0 @@ -From a9a8ed5895dcb3af2bb57ca1492ddc5e9432b2b7 Mon Sep 17 00:00:00 2001 -From: Leah Rowe -Date: Wed, 11 Dec 2024 01:06:01 +0000 -Subject: [PATCH 30/43] dell/3050micro: disable nvme hotplug - -in my testing, when running my 3050micro for a few days, -the nvme would sometimes randomly rename. - -e.g. nvme0n1 renamed to nvme0n2 - -this might cause crashes in linux, if booting only from the -nvme. in my case, i was booting from mdraid (sata+nvme) and -every few days, the nvme would rename at least once, causing -my RAID to become unsynced. since i'm using RAID1, this was -OK and I could simply re-sync the array, but this is quite -precarious indeed. if you're using raid0, that will potentially -corrupt your RAID array indefinitely. - -this same issue manifested on the T480/T480 thinkpads, and -S3 resume would break because of that, when booting from nvme, -because the nvme would be "unplugged" and appear to linux as a -new device (the one that you booted from). - -the fix there was to disable hotplugging on that pci-e slot -for the nvme, so apply the same fix here for 3050 micro - -Signed-off-by: Leah Rowe ---- - src/mainboard/dell/optiplex_3050/devicetree.cb | 4 +++- - 1 file changed, 3 insertions(+), 1 deletion(-) - -diff --git a/src/mainboard/dell/optiplex_3050/devicetree.cb b/src/mainboard/dell/optiplex_3050/devicetree.cb -index 0d2adff74a..829acacab3 100644 ---- a/src/mainboard/dell/optiplex_3050/devicetree.cb -+++ b/src/mainboard/dell/optiplex_3050/devicetree.cb -@@ -44,7 +44,9 @@ chip soc/intel/skylake - register "PcieRpAdvancedErrorReporting[20]" = "1" - register "PcieRpLtrEnable[20]" = "true" - register "PcieRpClkSrcNumber[20]" = "3" -- register "PcieRpHotPlug[20]" = "1" -+# disable hotplug on nvme to prevent renaming e.g. nvme0n1 rename to nvme0n2, -+# which could cause crashes in linux if booting from nvme -+ register "PcieRpHotPlug[20]" = "0" - end - - # Realtek LAN --- -2.39.5 - -- cgit v1.2.1