From ea9d1085297d581837cf45f3d1208ebf338af4eb Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Mon, 16 Mar 2026 21:06:15 +0000 Subject: util/nvmutil: fix mkstemp randomness i made the string longer, but forgot to adjust it. the new random function is also better Signed-off-by: Leah Rowe --- util/nvmutil/nvmutil.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/util/nvmutil/nvmutil.c b/util/nvmutil/nvmutil.c index 1f7f4af0..8fff62e4 100644 --- a/util/nvmutil/nvmutil.c +++ b/util/nvmutil/nvmutil.c @@ -3026,8 +3026,10 @@ x_i_mkstemp(char *template) char *p; char ch[] = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"; + unsigned long chlen; len = xstrxlen(template, PATH_LEN); + chlen = xstrxlen(ch, 100); /* find trailing XXXXXX */ if (len < 6) @@ -3038,7 +3040,7 @@ x_i_mkstemp(char *template) for (i = 0; i < 100; i++) { for (j = 0; j < 6; j++) - p[j] = ch[rlong() & 31]; + p[j] = ch[rlong() % chlen]; fd = open(template, O_RDWR | O_CREAT | O_EXCL, 0600); -- cgit v1.2.1