From 9fb489ac3eaa1782a747e177ad01aacc1ff0cc1e Mon Sep 17 00:00:00 2001
From: Leah Rowe <leah@libreboot.org>
Date: Thu, 18 May 2023 11:24:08 +0100
Subject: modify: clean up duplicated code

Signed-off-by: Leah Rowe <leah@libreboot.org>
---
 modify | 21 +++++++--------------
 1 file changed, 7 insertions(+), 14 deletions(-)

diff --git a/modify b/modify
index b54d92aa..5bab0a1a 100755
--- a/modify
+++ b/modify
@@ -51,10 +51,10 @@ main()
 	case "${option}" in
 	list)
 		printf "Options for mode '%s':\n\n" ${mode}
-		listoptions "${mode}"
+		listitems "${modify}/${mode}"
 		;;
 	all)
-		for option in $(listoptions "${mode}"); do
+		for option in $(listitems "${modify}/${mode}"); do
 			"${modify}/${mode}/${option}" $@
 		done
 		;;
@@ -71,21 +71,13 @@ main()
 	esac
 }
 
-# Takes exactly one mode as parameter
-listoptions()
-{
-	for option in "${modify}/${1}/"*; do
-		printf '%s\n' ${option##*/}
-	done
-}
-
 help()
 {
 	cat <<- EOF
 	USAGE:	./modify <MODE> <OPTION>
 
 	possible values for 'mode':
-	$(listmodes)
+	$(listitems "${modify}")
 
 	Example:	./modify coreboot configs
 	Example:	./modify coreboot configs x60
@@ -94,10 +86,11 @@ help()
 	EOF
 }
 
-listmodes()
+listitems()
 {
-	for mode in "${modify}/"*; do
-		printf '%s\n' "${mode##*/}"
+	for x in "${1}/"*; do
+		[ ! -f "${x}" ] && continue
+		printf "%s\n" ${x##*/}
 	done
 }
 
-- 
cgit v1.2.1