From 9372ae3ddcb63377b1ab0b77e4db4086deef3244 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Thu, 6 Apr 2023 19:41:53 +0100 Subject: util/nvmutil: one more comment --- util/nvmutil/nvmutil.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/nvmutil/nvmutil.c b/util/nvmutil/nvmutil.c index b77b28ad..a58f66a1 100644 --- a/util/nvmutil/nvmutil.c +++ b/util/nvmutil/nvmutil.c @@ -225,9 +225,10 @@ parseMacAddress(const char *strMac, uint16_t *mac) for (int nib = 0; nib < 2; nib++, total += h) { if ((h = hextonum(strMac[i + nib])) > 15) return -1; + /* ensure local, unicast mac address if random: */ if ((byte == 0) && (nib == 1)) if (strMac[i + nib] == '?') - h = (h & 0xE) | 2; + h = (h & 0xE) | 2; /* local, unicast */ mac[byte >> 1] |= ((uint16_t ) h) << ((8 * ((byte % 2) ^ 1)) + (4 * (nib ^ 1))); } -- cgit v1.2.1