From 92aa83a23696cd5706770af78d49858ef2d0c28d Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Sun, 16 Jun 2024 12:46:03 +0100 Subject: roms: simplify build_roms() cbcfg is already a global variable, so there's no reason to set it again at the start of this function. remove the check for whether the given coreboot config exists, to the calling function instead of build_roms(). Signed-off-by: Leah Rowe --- script/roms | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/script/roms b/script/roms index 99f53e00..ea2f4b26 100755 --- a/script/roms +++ b/script/roms @@ -184,16 +184,13 @@ build_board() [ "$displaymode" != "txtmode" ] && continue cbcfg="$targetdir/config/${initmode}_$displaymode" [ "$initmode" = "normal" ] && cbcfg="${cbcfg%_*}" - build_roms "$cbcfg"; x_ rm -f "$cbrom" + e "$cbcfg" f not || build_roms; x_ rm -f "$cbrom" done done } build_roms() { - cbcfg="$1" - e "$cbcfg" f not && return 0 - x_ ./update trees -b coreboot $board _cbrom="elf/coreboot_nopayload_DO_NOT_FLASH" -- cgit v1.2.1