From 82f38ed87a059a100b8d56150583cb3563962c37 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Mon, 16 Mar 2026 21:17:25 +0000 Subject: cleanup (fix potential overflow in mkstemp) Signed-off-by: Leah Rowe --- util/nvmutil/nvmutil.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/util/nvmutil/nvmutil.c b/util/nvmutil/nvmutil.c index 719a4810..5401c2eb 100644 --- a/util/nvmutil/nvmutil.c +++ b/util/nvmutil/nvmutil.c @@ -3039,10 +3039,9 @@ x_i_mkstemp(char *template) char *p; char ch[] = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"; - unsigned long chlen; + unsigned long r = rlong(); len = xstrxlen(template, PATH_LEN); - chlen = xstrxlen(ch, 100); /* find trailing XXXXXX */ if (len < 6) @@ -3053,7 +3052,7 @@ x_i_mkstemp(char *template) for (i = 0; i < 100; i++) { for (j = 0; j < 6; j++) - p[j] = ch[rlong() % chlen]; + p[j] = ch[r % (sizeof(ch) - 1)]; fd = open(template, O_RDWR | O_CREAT | O_EXCL, 0600); -- cgit v1.2.1