From 38c3889f67d91d9b4d4295514a08603b7db9f9c7 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Thu, 12 Mar 2026 14:32:46 +0000 Subject: util/nvmutil: improved entropy in fallback_rand Signed-off-by: Leah Rowe --- util/nvmutil/nvmutil.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/util/nvmutil/nvmutil.c b/util/nvmutil/nvmutil.c index e07efbb3..846eb2c3 100644 --- a/util/nvmutil/nvmutil.c +++ b/util/nvmutil/nvmutil.c @@ -1036,6 +1036,14 @@ fallback_rand(void) ^ (unsigned long)&mix ^ counter++; + /* + * Stack addresses can vary between + * calls, thus increasing entropy. + */ + mix ^= (unsigned long)&mix; + mix ^= (unsigned long)&tv; + mix ^= (unsigned long)&counter; + return (uint16_t)(mix & 0xf); } -- cgit v1.2.1