From 3162d60d5270412506c076749d65221fa6276f1f Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Thu, 12 Oct 2023 15:22:13 +0100 Subject: nvmutil: don't reset errno before write under the current logic, errno would be ECANCELED if neither checksum is valid, or I/O related if pwrite fails; alternatively, the for loop exits and the file has been written, where it is quite correctly reset already. ergo, the errno reset at the start of writeGbeFile is superfluous. remove this bloat. Signed-off-by: Leah Rowe --- util/nvmutil/nvmutil.c | 1 - 1 file changed, 1 deletion(-) diff --git a/util/nvmutil/nvmutil.c b/util/nvmutil/nvmutil.c index fe0df3d1..e99c6ade 100644 --- a/util/nvmutil/nvmutil.c +++ b/util/nvmutil/nvmutil.c @@ -261,7 +261,6 @@ xorswap_buf(int partnum) void writeGbeFile(void) { - errno = 0; err_if((cmd == writeGbeFile) && !(validChecksum(0) || validChecksum(1))); for (int p = 0, x = (cmd == writeGbeFile) ? 1 : 0; p < 2; p++) { if ((!nvmPartModified[p]) && (cmd != writeGbeFile)) -- cgit v1.2.1