lbmk.git/util/nvmutil, branch c20230710

util/nvmutil: reduced indentation inside loop

2023-06-14T09:56:11+00:00

Signed-off-by: Leah Rowe

util/nvmutil: call unveil earlier, and harden

2023-06-03T20:03:21+00:00

The mentality behind pledge and unveil is that you should
think ahead, so that large parts of code can run under
extremely tight restrictions.

The pledge calls have been adjusted accordingly, also.
Disallow all unveil calls after the gbe file and the
file /dev/urandom have been unveiled.

Signed-off-by: Leah Rowe

util/nvmutil: hardening: reduce pledges earlier

2023-06-03T18:44:14+00:00

also remove wpath if using the dump command

Signed-off-by: Leah Rowe

util/nvmutil: fix faulty arg check

2023-06-03T14:08:29+00:00

in practise, no other condition would be met and the
program still worked. this is a pre-emptive fix.

util/nvmutil: cleanup: move logic out of main()

2023-06-03T12:44:04+00:00

Signed-off-by: Leah Rowe

util/nvmutil: major cleanup. simpler arg handling.

2023-06-03T12:36:10+00:00

Also hardened the pledges.

Signed-off-by: Leah Rowe

util/nvmutil: simplify writeGbeFile()

2023-06-02T10:52:49+00:00

Signed-off-by: Leah Rowe

util/nvmutil: don't call writeGbeFile if O_RDONLY

2023-06-01T13:07:20+00:00

This replaces a check in the function for O_RDONLY, and
fixes the bug where the "dump" command triggers such error.

Signed-off-by: Leah Rowe

util/nvmutil: code cleanup (pledge/unveil calls)

2023-06-01T13:04:44+00:00

Signed-off-by: Leah Rowe

util/nvmutil: harden pledge/unveil calls (OpenBSD)

2023-06-01T12:35:34+00:00

*Open* files at the start, then unveil. The same overall
behaviour is observed. In the case that invalid arguments
are given, simply opening a file does not cause much
performance impact (if any).

Restrict operations as early as possible in code.

Bonus:

writeGbeFile also hardened; if flags is O_RDONLY, it aborts.

Signed-off-by: Leah Rowe