lbmk.git/script/roms, branch audit6-merge1

roms: rename x variable to it in for loop

2024-06-17T00:05:28+00:00

there are two for loops that use x as a variable anme,
and an idiosyncrasy of certain sh implementations is
that these become global;

the result in this case was that when you finish building
every target in "./build roms", it would print "libgfxinit"
repeatedly, comma separated, instead of a comma-separated
list of the targets that were built.

work around it by renaming the variable in one of the loops.

Signed-off-by: Leah Rowe

roms: don't use x_ to call cproms()

2024-06-16T16:56:41+00:00

cproms() never returns non-zero, so it doesn't make
sense to use x_ here

Signed-off-by: Leah Rowe

roms build_uboot_roms(): move rom, don't copy

2024-06-16T16:50:42+00:00

that way, we don't have to delete the temporary file.
just move it entirely.

Signed-off-by: Leah Rowe

roms cproms(): allow other commands besides cp

2024-06-16T16:50:13+00:00

e.g. the operator might specify mv instead

Signed-off-by: Leah Rowe

unify coreboot elfdir (DO_NOT_FLASH)

2024-06-16T16:46:58+00:00

use a common string when setting this path

Signed-off-by: Leah Rowe

roms: merge mkUbootRom() into build_uboot_roms()

2024-06-16T16:42:34+00:00

Signed-off-by: Leah Rowe

roms: simplify mkSeabiosRom()

2024-06-16T11:54:07+00:00

remove variables that are not meaningfully used

Signed-off-by: Leah Rowe

roms: simplify mkUbootRom()

2024-06-16T11:51:47+00:00

remove variables that are not meaningfully used

Signed-off-by: Leah Rowe

roms: simplify build_roms()

2024-06-16T11:46:03+00:00

cbcfg is already a global variable, so there's no reason
to set it again at the start of this function.

remove the check for whether the given coreboot config
exists, to the calling function instead of build_roms().

Signed-off-by: Leah Rowe

roms: remove unnecessary check

2024-06-16T11:42:57+00:00

uboot_config is later only used if payload_uboot is set

Signed-off-by: Leah Rowe