lbmk.git/mk, branch 25.04_branch libreboot build system (LibreBoot MaKe) mk: add missing error handli for mk -f 2025-05-08T21:17:35+00:00 Leah Rowe leah@libreboot.org 2025-05-08T21:17:35+00:00 1ce3e7a3d39cced1749b909fba9228b877c77339 on the release command, that is Signed-off-by: Leah Rowe <leah@libreboot.org> 
on the release command, that is

Signed-off-by: Leah Rowe <leah@libreboot.org>
lib.sh: Simplified fx_() and removed fe_() 2025-05-07T14:12:10+00:00 Leah Rowe leah@libreboot.org 2025-05-07T14:12:10+00:00 ec5c954337b2e1ea50b0ace0f1086e48f20e7774 Instead of calling fe_, prefix x_ as indicated. Signed-off-by: Leah Rowe <leah@libreboot.org> 
Instead of calling fe_, prefix x_ as indicated.

Signed-off-by: Leah Rowe <leah@libreboot.org>
mk: Create serprog tarballs here instead 2025-05-07T13:21:28+00:00 Leah Rowe leah@libreboot.org 2025-05-07T13:19:15+00:00 1390f7f800767dcba394ebbc4f7996508940639e i simplified rom.sh to use mkhelper for actual image building. Signed-off-by: Leah Rowe <leah@libreboot.org> 
i simplified rom.sh to use mkhelper for actual image
building.

Signed-off-by: Leah Rowe <leah@libreboot.org>
lib.sh: support any command on find_exec() 2025-05-07T12:28:55+00:00 Leah Rowe leah@libreboot.org 2025-05-07T12:27:25+00:00 0faef899469818410e5e6d481f1e6c4fa5ad3d3d right now, we assume "find", but it adds any number of arguments next to that. change it instead to support any command, where the assumption is that it would generate a list of files and directories. Signed-off-by: Leah Rowe <leah@libreboot.org> 
right now, we assume "find", but it adds any number of
arguments next to that.

change it instead to support any command, where the
assumption is that it would generate a list of files
and directories.

Signed-off-by: Leah Rowe <leah@libreboot.org>
singletree/elfcheck: use fx_, not fe_ 2025-05-05T19:33:02+00:00 Leah Rowe leah@libreboot.org 2025-05-05T19:33:02+00:00 f98e34a24dd21ebafbfac2e019d3a4bc1cf500cb fe_ returns an error on the find command, but we rely on the only error ever being our intentional exit, upon discovering files. in singletree, the directory being checked was already checked first, so we know it's safe not to err on find; and find not reporting an error if no files are found is ok. on elfcheck, it's very much the same thing. In fact, we very much want it to return 0 if the directory doesn't exist, or if files don't exist within it. Therefore, use fx_ which is designed for this use-case. Quick re-cap: fx and fe execute a given function name with each line outputting by find as an argument, each time. It is somewhat similar in scope to find's -exec command. We use fe_ as shorthand in several places all over lbmk. Signed-off-by: Leah Rowe <leah@libreboot.org> 
fe_ returns an error on the find command, but we rely
on the only error ever being our intentional exit, upon
discovering files.

in singletree, the directory being checked was already
checked first, so we know it's safe not to err on find;
and find not reporting an error if no files are found is
ok.

on elfcheck, it's very much the same thing. In fact, we
very much want it to return 0 if the directory doesn't
exist, or if files don't exist within it.

Therefore, use fx_ which is designed for this use-case.

Quick re-cap: fx and fe execute a given function name with
each line outputting by find as an argument, each time. It
is somewhat similar in scope to find's -exec command.

We use fe_ as shorthand in several places all over lbmk.

Signed-off-by: Leah Rowe <leah@libreboot.org>
mk: simplify elfcheck() 2025-05-05T14:51:04+00:00 Leah Rowe leah@libreboot.org 2025-05-05T14:51:04+00:00 c2182d821939a7d3c3e8ff2b6ff96e9e44ff96fa fe_() called inside subshell, ftw Signed-off-by: Leah Rowe <leah@libreboot.org> 
fe_() called inside subshell, ftw

Signed-off-by: Leah Rowe <leah@libreboot.org>
mk: Fix bad error handling for gnu_setver 2025-05-05T11:16:18+00:00 Leah Rowe leah@libreboot.org 2025-05-05T10:54:23+00:00 6b247c93e25f7283524edb6b6e19ca3296c78006 I mixed logical OR and AND by mistake. Oops! Signed-off-by: Leah Rowe <leah@libreboot.org> 
I mixed logical OR and AND by mistake. Oops!

Signed-off-by: Leah Rowe <leah@libreboot.org>
lbmk: MUCH safer err function 2025-05-04T09:13:42+00:00 Leah Rowe leah@libreboot.org 2025-05-04T08:56:21+00:00 54291ebb7209c314bb52f507bc6a1ecf2a28fbc9 Don't directly call a variable. Call a function that checks the variable instead. The new err function also checks whether an exit was actually done, and exits 1 if not. If an exit was done by the given function, but the exit was zero, this is also corrected to perform an exit 1. This fixes a longstanding design flaw of lbmk. Signed-off-by: Leah Rowe <leah@libreboot.org> 
Don't directly call a variable. Call a function that
checks the variable instead.

The new err function also checks whether an exit was
actually done, and exits 1 if not.

If an exit was done by the given function, but the exit
was zero, this is also corrected to perform an exit 1.

This fixes a longstanding design flaw of lbmk.

Signed-off-by: Leah Rowe <leah@libreboot.org>
mk: tidy up xgccargs handling 2025-05-04T07:15:00+00:00 Leah Rowe leah@libreboot.org 2025-05-04T07:14:44+00:00 fc71e52fdfc559d207ea54059a86edb81e928e33 Signed-off-by: Leah Rowe <leah@libreboot.org> 
Signed-off-by: Leah Rowe <leah@libreboot.org>
mk: remove useless code 2025-05-04T07:10:59+00:00 Leah Rowe leah@libreboot.org 2025-05-04T07:10:59+00:00 184871bc17cdc5716d8d8bcfff03b0f7412b7a1a this was added a few commits ago, but the previous commit made me realise it's not needed at all. Signed-off-by: Leah Rowe <leah@libreboot.org> 
this was added a few commits ago, but the previous commit
made me realise it's not needed at all.

Signed-off-by: Leah Rowe <leah@libreboot.org>