lbmk.git/include, branch 20231021fix2

20231021hotfix: replace x_ with err in some places

2023-10-22T11:34:45+00:00

keymaps weren't being set in keymay.cfg of cbfs, due
to use of x_ in the rom script, and x_ doesn't handle
quotes or spaces in arguments well.

i'm going to remove use of x_ and xx_ (it's in my todo),
for next release.

for now, hot patch the release. i've gone through and
replaced use of x_ with || err, in some places.

not just the keymap.cfg command, but others too. in case
there are more issues we missed.

this commit is being tagged "20231021fix" and i'm using
this tag to re-build the 20231021 release. i'll just
replace the tarballs in rsync and add errata to the news
page announcing the release. all i did was break peoples
umlauts, i didn't brick their machines fortunately!

very minor bug. anyway, x_/xx_ is a great idea, but sh
isn't really designed for that style of programming. i'll
go back to using just || err in the next release.

Signed-off-by: Leah Rowe

move git_init to the main build script

2023-10-20T20:10:26+00:00

also, don't use x_ because it totally b0rks on
these commands. handle exit status directly.

Signed-off-by: Leah Rowe

always re-generate .git in lbmk

2023-10-20T10:16:25+00:00

in release archives, .git is excluded but the version
and versiondate files are included. from these, the
git history is re-created with the exact date (but not
taking into account timezone, at present).

in this way, lbmk will have git history in a release
archive. some build systems, like coreboot, prefer that
there be git history available, so this is a nice
workaround on those build systems.

Signed-off-by: Leah Rowe

include/git: fix already-exists download message

2023-10-20T08:13:49+00:00

i forgot to put the download path in printf

Signed-off-by: Leah Rowe

Revert "Revert "include/git: don't re-download single-trees""

2023-10-20T08:12:23+00:00

This reverts commit baa3d4f217863ff34c03d54c4014f53812ae12ec.

include/git: fix error caused by sh idiosyncrasy

2023-10-20T08:11:29+00:00

when [] is used right at the end of a function, or
certain loops/subshells, some sh implementations will
just return a non-zero exit

Signed-off-by: Leah Rowe

Revert "include/git: don't re-download single-trees"

2023-10-20T07:58:02+00:00

This reverts commit 8de7bc93397a95312b742bc5af733208f702f3a8.

include/git: don't re-download single-trees

2023-10-20T07:54:01+00:00

only do it if the target source tree does not exist

Signed-off-by: Leah Rowe

update/trees: don't run make if mode=fetch

2023-10-20T07:45:57+00:00

this fixes a regression caused by a previous revision

Signed-off-by: Leah Rowe

include/git: fetch submodules on one-tree projects

2023-10-20T06:50:47+00:00

only fetch if .gitmodules exists

in some cases, lbmk is compiling source trees that
use submodules, without having downloaded them first.

in all cases, those submodules are either optional,
or the build system auto-fetches them (or if it can,
we sometimes disable it as with grub and gnulib).

this is a nice fallback behaviour, for situations where
we forget to put submodules as dependencies under
config/git (and disable submodules in the given project).

with this change, release archives are guaranteed to
be complete, sans crossgcc downloads in coreboot; this
will be handled in a follow-up commit.

Signed-off-by: Leah Rowe