Yes.

Thank you Johann C. Rode for this excellent coreboot port.

You're a star.

Signed-off-by: Leah Rowe <leah@libreboot.org>

Patch in Gerrit: https://review.coreboot.org/c/coreboot/+/89281
Not working: USB3 ports only work at USB2 speeds.

IFD:
Modified the original by:
- Removing Device Exp2 region (empty anyway)
- Enlarging the BIOS region to use this freed space
- Setting the HAP bit in PCHSTRP55 using a fork of
  me_cleaner: https://github.com/XutaxKamay/me_cleaner

Signed-off-by: Riku Viitanen <riku.viitanen@protonmail.com>
Signed-off-by: Leah Rowe <leah@libreboot.org>

i did:

ifdtool -f layout.txt ifd.bin

changed layout.txt to say this:

00000000:00000fff fd
00019000:007fffff bios
00001000:00018fff me
00fff000:00000fff gbe
00fff000:00000fff pd

then i did:

ifdtool -n layout.txt ifd.bin -O ifd.bin

this was done to the ifd for hp 3500 pro, based on
the 96KB size of the truncated me.bin via me_cleaner,
when downloading vendor files in lbmk.

it's the policy of libreboot that me.bin should always
be shrunk, and the BIOS region enlarged.

in the original HP 3500 PRO patch submitted, the ME region
was larger, with region boundaries like this:

00000000:00000fff fd
00400000:007fffff bios
00001000:003fffff me
00fff000:00000fff gbe
00fff000:00000fff pd

In the above example, you see that the BIOS region is 4MB.

In the new setup, BIOS is about 7.9MB.

Signed-off-by: Leah Rowe <leah@libreboot.org>

coreboot already unlocks the regions during build, by default,
anyway, and this was present in the submitter's patch.

however, it's also good to unlock the IFD regions. like so:

ifdtool --unlock ifd.bin -O ifd.bin

this has been done, on the ifd for hp pro 3500

Signed-off-by: Leah Rowe <leah@libreboot.org>

ifdtool --altmedisable 1 ifd.bin -O ifd.bin

always remember to do this, when adding a new
ifd to lbmk. i merged the 3500 port anyway, since
the submitted already used me_cleaner anyway, but
setting the HAP bit is also useful. for example, if
someone was to only flash the BIOS region, which is
possible in this case since the submitter also
didn't truncate the ME region or enlarge the BIOS
region.

in that case, flashing IFD and BIOS is another valid
way to do it, where IFD's HAP bit is set

Signed-off-by: Leah Rowe <leah@libreboot.org>

Everything should work except cpu fan control because ME cleaning breaks PECI.

In practise, coreboot can set this bit at build time.
We also use ME Soft Temporary Disable by default, on
this platform.

We also use me_cleaner by default, so the me.bin file
added to flash only contains the code that would run
with HAP set anyway.

Therefore, this change is of little practical consequence,
but as a friend put it to me, this change is most technically
correct.

And I'm all about technical correctness.

Signed-off-by: Leah Rowe <leah@libreboot.org>

i used ifdtool --unlock to do this

Signed-off-by: Leah Rowe <leah@libreboot.org>

no-ME setup. with a gbe file. we previously made this
a descriptorless setup.

Signed-off-by: Leah Rowe <leah@libreboot.org>

Signed-off-by: Leah Rowe <leah@libreboot.org>