WARNING!!!!! i915 driver crashes when loading (KMS driver). Could not use GRUB or SeaBIOS; SeaBIOS hangs and USB input fails in GRUB. U-Boot UEFI works, you can boot things. If you want to set upp a headless service this machine is totally fine, because you can just avoid loading i915 in Linux, and just use the EFI framebuffer or the coreboot framebuffer, or possibly boot xorg with nomodeset. DO NOT MERGE! This machine needs a lot work work. Initial notes: This should cover both the M920q and M920x, though the x variant is quite rare. This is a mITX desktop system, documented here: https://doc.coreboot.org/mainboard/lenovo/m920q.html Thanks go to Maciej Pijanowski, who ported coreboot to this board and submitted the code upstream. Libreboot is using the version that was recently merged upstream in the coreboot project. It's not yet known how to auto-download the ME, because the update images are incomplete. The only reliable way thus far is to extract the factory dump. However, it's also uncertain what modules to whitelist in me_cleaner, so for this board, we only: * Unlock all IFD regions, setting them read-write * Set the HAP bit, which is functionally equivalent to a valid me_cleaner setup The result will be a disabled ME, and read-write operation. No binary images will be provided for now, in releases. You must also create the directory: dump/m920q/ Then just extract from the factory dump using: ./ifdtool --platform cnl -x libreboot.rom Then just stick the files that it creates into there, and the build should work. I've made lbmk automatically set the HAP bit and unlock regions, when building with these. Also, SeaBIOS hung so I restored the possibility of using GRUB as primary, but GRUB USB input also didn't work! The board's port author tested edk2 only, it seems. I don't really want edk2 in lbmk just for this board. So, I made U-Boot the only payload. It seems to work fine. However, Debian Linux and OpenBSD both seemed to completely fail: On OpenBSD it had errors pertaining to i915 video driver. Debian Linux stalled at startup just when it's switching to KMS, which would use the i915 driver. Arch Linux installer, same thing: uses KMS, and failed. The port author said edk2 was tested. edk2 provides a decent GOP implementation, so maybe they were using an EFI framebuffer when booting Linux. Signed-off-by: Leah Rowe <leah@libreboot.org>
Patchset 20 from: https://review.coreboot.org/c/coreboot/+/83274/18..20 Updated to that. A bunch of changes I made locally have been copied here, thus removed from lbmk. The previous setup in lbmk was to have only the DIMM slot work, on the ThinkPad T480S, without setting up SPD for the onboard RAM> Mate Kukri reverse engineered the scheme by which the SPDs are chosen at boot, based on the wiring of the board. This should just about match the way Lenovo did it in their firmware. Signed-off-by: Leah Rowe <leah@libreboot.org>
This fixes an error where nvme disappears and gets renamed on s3 resume. Mate Kukri told me to test that and it worked. Signed-off-by: Leah Rowe <leah@libreboot.org>
I also enabled this on T480S, because otherwise SeaBIOS hung. Enabling it shouldn't cause any harm on the T480, though Mate did say that his machine seemed to work with my setup. However, I believe that was when I gave him the ones that lbmk built with the VGA ROM. Now it builds with libgfxinit, because Mate was able to fix libgfxinit on this machine. Signed-off-by: Leah Rowe <leah@libreboot.org>
was previously using the VGA ROM. Signed-off-by: Leah Rowe <leah@libreboot.org>
Added t480s delta to deguard, for MFS config. Updated coreboot/next to latest t480 patch set, which includes t480s. This porting was done by Mate Kukri. also includes experimental t480s support Also added a data.vbt file (not in the gerrit patch) for the T480s. I had to turn on 8254 legacy timer on t480s, otherwise SeaBIOS would hang. Same issue I saw on OptiPlex 3050 Micro. Minor issue: On S3 resume, nvme0n1 for example got renamed to nvme0n2. This caused a crash if running Linux from the nvme. I confirmed this via live USB distro. So this port will need some tweaking before it can be considered stable. Also uses libgfxinit, which Mate recently fixed. I'm going to enable libgfxinit on regular T480 next. Signed-off-by: Leah Rowe <leah@libreboot.org>
This uses the excellent deguard utility, written by the excellent Mate Kukri. A few bugs but it mostly works. Documentation to come shortly, in lbwww.git. Signed-off-by: Leah Rowe <leah@libreboot.org>
This uses the "normal" config. Previous changes prevent U-Boot images being built for this anyway, but it does yield a warning message. Remove the warning at the source. Signed-off-by: Leah Rowe <leah@libreboot.org>
dGPU only, and starts in text mode. will have to test with vesa framebuffer later on. Signed-off-by: Leah Rowe <leah@libreboot.org>
there's a uart on the docking station Signed-off-by: Leah Rowe <leah@libreboot.org>